Updates every app that was wrapping query in an array unnecessarily #27636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
added
Feature:Dashboard
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug @lukasolson and I found where some TSVB, Timeline, and Vega were not responding to queries in the dashboard query bar.
These apps were wrapping the
queryparam passed in by the canvas pipelinecontextin an array even though that query param was already an array and did not need wrapping. This bug was most likely introduced in #25996 when the canvas pipeline was introduced to visualize.